test: expand concurrency validation methodology#97
Conversation
|
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 95a1f6c6af
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| i=1 | ||
| while [[ "$i" -le "$LOOPS" ]]; do | ||
| echo "concurrency stress loop $i/$LOOPS" | ||
| ctest --preset "$PRESET" -L "$LABEL" --output-on-failure |
There was a problem hiding this comment.
When QSL_CONCURRENCY_STRESS_LABEL is mistyped, or if the CTest labels/discovery regress, this ctest -L invocation can match zero tests and still let every loop report success; checked ctest --help, which documents --no-tests=<[error|ignore]>, and the default empty selection exits 0. Add --no-tests=error here so the stress target cannot produce false validation without running any concurrency tests.
Useful? React with 👍 / 👎.
1 participant
Summary
PipelinePerturbationhooks to the threaded pipeline so tests can force per-stage yields without sleeps or timing-sensitive assertions.make concurrency-stress/scripts/concurrency_stress.shas an explicit opt-in repeated concurrency-label test loop.Scope
M33 only. This does not start M34, does not change gateway architecture, and does not make production latency or full correctness-proof claims.
Verification
make check- 189/189 passedmake asan- 189/189 passedmake tsan- 19/19 concurrency-labelled tests passedQSL_CONCURRENCY_STRESS_LOOPS=2 make concurrency-stress- 2/2 loops passedbash -n scripts/concurrency_stress.shgit diff --checkFollow-up
After this merges,
/start-milestone 34begins the epoll gateway architecture milestone. Issue #90 remains the separate PMU-capable Linux perf evidence debt.