Skip to content

Fixes - #88

Merged
divyeshio merged 4 commits into
mainfrom
fixes
Mar 3, 2026
Merged

divyeshio merged 4 commits into
mainfrom
fixes

Conversation

@divyeshio

Copy link
Copy Markdown
Owner

No description provided.

…neration script

- Added a new script "tools:build" to generate tools.json from tools-collection.
- Updated "build" script to run tools:build before vite build.
- Updated dependencies: "@ai-sdk/openai" to "^3.0.39" and "ai" to "^6.0.108".
- Added new dependency "@tanstack/react-store" and "nitro".

chore: create public/tools.json with tool definitions

- Added a new tools.json file containing metadata for various tools.

fix: update json-output component for ScrollArea styling

- Adjusted className for ScrollArea in json-output component to fix styling issues.

feat: implement script to generate tools.json from tools-collection

- Created generate-tools-json.ts script to read tool definitions from JSON files and output a consolidated tools.json.

chore: add skills-lock.json for skill management

- Introduced skills-lock.json to manage skill dependencies.

fix: improve theme switcher component for hydration issues

- Added mounted state to prevent hydration mismatch in theme switcher.

refactor: clean up tool-card component

- Removed unused navigation logic and simplified tool-card component.

fix: update tools.api.ts for fetching tools

- Refactored fetchTools to use createIsomorphicFn for server and client fetching.

fix: update routeTree for consistent route paths

- Adjusted route paths to ensure trailing slashes are consistent.

refactor: rename createRouter to getRouter in router.tsx

- Renamed createRouter function to getRouter for clarity.

fix: update root component for consistent navbar behavior

- Removed pathname dependency from RootDocument to simplify rendering logic.

fix: update tools index route for fetching tools

- Refactored tools index route to use fetchToolsList and removed local tools loading logic.

chore: update tsconfig for stricter type checking

- Changed target to "esnext" and enabled strict mode for better type safety.

chore: update vite.config for improved build configuration

- Added tailwindcss plugin and adjusted prerender settings for better output.
- Refactored command generation logic to use useCallback for better performance.
- Updated parameter input components for better separation of concerns and reusability.
- Enhanced type safety in flattenImportedData function by specifying Record types.
- Simplified command tree rendering by creating a CommandNode component.
- Improved parameter list rendering with a dedicated ParameterIcon component.
- Added error handling improvements in AI parsing and import components.
- Updated TypeScript configuration to skip library checks for faster builds.
- Cleaned up vitest configuration for better readability and maintainability.
Copilot AI review requested due to automatic review settings March 3, 2026 18:36

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the app’s build/tooling pipeline (Vite/Vitest/TS config, formatting/linting, Nitro), refactors parts of the tools data flow to use a generated public/tools.json, and includes several UI + component refactors across the Commandly tool editor/runtime preview.

Changes:

  • Simplifies Vitest config and updates Vite build settings/plugins (Tailwind Vite plugin, output dir changes).
  • Introduces generated public/tools.json + isomorphic fetching logic for the tools list, and wires routes to use it.
  • Applies multiple UI/component refactors (command tree, runtime preview parameter inputs, hooks deps cleanup) and adds Oxlint/Oxfmt configuration.

Reviewed changes

Copilot reviewed 46 out of 48 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
vitest.config.ts Stops merging Vite config; defines Vitest config directly with tsconfig paths plugin config.
vite.config.ts Adds Tailwind Vite plugin, tweaks prerender options, sets build outDir to build.
tsconfig.json Updates TS target/module/strictness and excludes vitest config.
src/routes/tools/index.tsx Switches tools list fetching to fetchToolsList; removes local tool merge logic; Tailwind class changes.
src/routes/tools/$toolName/index.tsx Hook ordering fix; adds query-state for command selection; ScrollArea selector change.
src/routes/index.tsx Tailwind v4-style class updates and image layout changes for Tabs content.
src/routes/__root.tsx Removes pathname-based conditional layout; adjusts Tailwind variants for backdrop-filter.
src/router.tsx Renames router factory to getRouter and updates module augmentation.
src/routeTree.gen.ts Route path typing updates and adds react-start Register augmentation for SSR/router typing.
src/lib/api/tools.api.ts Adds isomorphic tools list fetch (server reads public/tools.json, client fetches local/Raw GitHub).
src/components/tool-editor-ui/tool-card.tsx Removes imperative navigation handler; uses Link preload intent.
src/components/tool-editor-ui/manual-new-tool.tsx Fixes hook deps (useEffect depends on callback).
src/components/tool-editor-ui/import.tsx Fixes hook deps and hardens toast error handling.
src/components/tool-editor-ui/ai-parsing.tsx Improves error display, stabilizes validation callback, fixes deps, Tailwind sizing changes.
src/components/theme-switcher.tsx Adds mounted guard to avoid hydration mismatch for theme icon.
src/components/not-found.tsx Tightens children typing and adds explicit React import.
skills-lock.json Adds agent skill lock metadata.
scripts/generate-tools-json.ts Adds script to generate public/tools.json from public/tools-collection.
registry/commandly/ui/tags-input.tsx Refactors away from forwardRef, improves typings and disable logic.
registry/commandly/tool-editor/parameter-list.tsx Extracts parameter icon rendering and tightens store state typing.
registry/commandly/tool-editor/command-tree.tsx Refactors command tree into recursive CommandNode component.
registry/commandly/runtime-preview.tsx Refactors parameter input rendering into smaller components.
registry/commandly/lib/utils/commandly.ts Replaces any with typed Record<string, unknown> parsing/casts in flattening logic.
registry/commandly/lib/types/commandly-nested.ts Updates import source for shared enums/types.
registry/commandly/json-output.tsx Updates ScrollArea viewport selector class.
registry/commandly/generated-command.tsx Memoizes command generation and fixes effect deps.
registry/commandly/tests/tool-editor/parameter-list.test.tsx Replaces var with const.
registry/commandly/tests/tool-editor/dialogs/parameter-details-dialog.test.tsx Updates store state setting to functional updater form.
registry/commandly/tests/tool-editor/dialogs/command-dialog.test.tsx Updates store state setting to functional updater form.
registry/commandly/tests/tool-editor/command-tree.test.tsx Tightens types (Command) and replaces var with const.
registry/commandly/tests/generated-command.test.tsx Fixes mock path and expands mocked store shape.
public/tools.json Adds generated tools index JSON.
package.json Adds tools build step, switches formatting scripts to oxfmt, updates dependencies (incl. Vite 8 beta).
nitro.config.ts Updates Nitro config style and sets Vercel config version.
bun.lock Lockfile updates for dependency changes.
.oxlintrc.json Adds Oxlint configuration.
.oxfmtrc.json Adds Oxfmt configuration (incl. Tailwind experimental formatting config).
.agents/skills/vercel-composition-patterns/* Adds agent skill documentation/rules bundle.

Comment thread src/routes/index.tsx Resolved
Comment thread registry/commandly/json-output.tsx Resolved
Comment thread src/routes/tools/$toolName/index.tsx Resolved
Comment thread src/routes/tools/index.tsx Resolved
Comment thread src/routes/tools/index.tsx Resolved
Comment thread src/routes/tools/$toolName/index.tsx Resolved
Comment thread src/routes/index.tsx Resolved
…erformance

- Updated edit.tsx and index.tsx to streamline imports and enhance loader functionality.
- Consolidated tool data fetching and validation logic for better readability.
- Improved component structure and styling in the tool listing page.
- Enhanced user experience by refining button actions and tool display elements.
- Adjusted CSS variables for consistent shadow effects across components.
- Updated Vite and Vitest configurations for better plugin management and build performance.
@divyeshio
divyeshio merged commit b51890b into main Mar 3, 2026
6 checks passed
@divyeshio
divyeshio deleted the fixes branch March 3, 2026 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants