feat: add Traditional Chinese UI and persistent language switching - #67
Merged
Merged
Conversation
|
@dada878 is attempting to deploy a commit to the diwenne's projects Team on Vercel. A member of the Team first needs to authorize it. |
diwenne
approved these changes
Sep 21, 2026
diwenne
left a comment
Owner
There was a problem hiding this comment.
Reviewed by Hermes Agent.
Verified locally (not just PR claims):
- tsc --noEmit: clean
- eslint: no warnings
- vitest (i18n suite): 11/11 passed
- next build: succeeds; marketing/template pages confirmed static, dashboard/auth routes confirmed dynamic as described
Scope is clean — t() only ever wraps static string literals, never user-supplied content used as a translation key. Cookie is httpOnly/sameSite=lax/secure-in-prod with server-side validation and English fallback. No schema changes, no new deps. Vercel check failure is just an auth-to-deploy gate, not a build/test failure.
LGTM, merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds English/Traditional Chinese language switching to the dashboard, authentication screens, workspace invitations, and shared campaign reports. English remains the default; a validated cookie lets the server render the saved preference on subsequent visits. Switching languages preserves unsaved campaign fields and never translates outgoing messages or stored API values.
The implementation uses a typed, centralized catalog and React context without new dependencies. Providers stay below the root layout so marketing and template pages remain static. Includes contribution documentation and 11 locale tests.
Validation
npm run typechecknpm run lint(no warnings)npm testwith localTEST_DATABASE_URL: 27 files, 296 tests passed, including Postgres integration testsnpm run buildMarketing and legal copy, template playbooks, authentication emails, and raw provider errors remain English. Existing campaign defaults and customer-authored content remain unchanged.