fix: Restore MSIX startup support, add Help menu and Windows startup settings button#127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
MSIX users lost the ability to start Spice with Windows after migrating away from the ISS installer. This PR restores startup support for MSIX via the
desktop:StartupTaskmanifest extension, adds a "Manage in Windows Settings" button so all Windows users (MSIX and ISS) can manage startup behavior, adds a Help entry to the system tray menu pointing to the support page, and updates the support page with a user guide reference.Changes
desktop:StartupTasktomsix/AppxManifest.xml(enabled by default, user-toggleable via Windows Settings)ButtonItemto General Settings (Windows-only) that opensms-settings:startupappshelp.pngicon above "About Spice", linking tohttps://spicebox.dev/support.htmlconfig/const.goinit() to use taggedswitchonruntime.GOOSType of change
How Has This Been Tested?
make win-amd64pipeline: gen-i18n ✓, linting ✓, all 44 test packages pass ✓ms-settings:startupappscorrectlyruntime.GOOSguardmake check-i18npasses with all 10 languages translatedChecklist: