Fix first person rendering of columns with every cube filled - #5200
Merged
Loobinex merged 1 commit intoSep 5, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been doing some experiments with maps in KeeperFX and found a bug.
I created a modified version of the Eversmile map featuring a large pyramid to showcase all possible height levels.
Eversmile with a big room with a piramid (all is well rendered):

Now with possession mode (bug, the topmost level of the pyramid has a wall extending all the way up to the ceiling):

Walking in possession mode on the topmost level of the pyramid shows no floor:

Fixed:

The ceiling vertex and the top corner of a fully-filled column (all
COLUMN_STACK_HEIGHT cubes) shared the same slot in
struct EngineCol. Theceiling gets written after the column, so it overwrites that corner, and the
column's top face and topmost side stretch up to ceiling height instead of
its own.
Never showed up before because every fully-filled column in the stock maps is
blocking, and a blocking column's own height is also its ceiling, so the two
values always matched by coincidence. Shows up on a walkable one, whose
ceiling comes from the surrounding walls instead.
Isometric and cluedo view are unaffected, they don't draw a ceiling.
Gives the ceiling its own slot past the cube and abyss-wall ones.