Skip to content

Emily#32

Open
emilyytruong wants to merge 5 commits into
mainfrom
emily
Open

Emily#32
emilyytruong wants to merge 5 commits into
mainfrom
emily

Conversation

@emilyytruong
Copy link
Copy Markdown
Collaborator

First pull request for static tree view

@dkim157
Copy link
Copy Markdown
Owner

dkim157 commented Nov 19, 2021

Looks good to me! good job with the research as well you picked a good library to model with

Comment thread backend/src/.cache Outdated
@@ -1 +1 @@
{"access_token": "BQA9_9inph0wpoqu3S2pLbLv9sgPjDnO7K0t-V35MktKAVbn94Knr9xjKyEH66yKJ7ZvJyIlZnQYj75qjiw", "token_type": "Bearer", "expires_in": 3600, "expires_at": 1636143399} No newline at end of file
{"access_token": "BQDu5b9CCeqfrykgeC4mUP0KojCNLCJNzOE7r6JLTTPoVU5wi1fBCNWxwa_0QiELWYXeogNYmb3lUbqZdeA", "token_type": "Bearer", "expires_in": 3600, "expires_at": 1637012366} No newline at end of file
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Simple token change :0)

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the comment!

@jhtranx
Copy link
Copy Markdown
Collaborator

jhtranx commented Nov 19, 2021

Nice work with the nodes this must've been pretty difficult. We should get to merge conflicts but I can help with that

@jettcost38
Copy link
Copy Markdown
Collaborator

All is looking great. Can't wait to implement dynamic tree! Great work!

@emilyytruong
Copy link
Copy Markdown
Collaborator Author

Looks good to me! good job with the research as well you picked a good library to model with

Thank you for the comment!

@emilyytruong
Copy link
Copy Markdown
Collaborator Author

Nice work with the nodes this must've been pretty difficult. We should get to merge conflicts but I can help with that

Okay, sounds good with me! Thank you for all the help

@emilyytruong
Copy link
Copy Markdown
Collaborator Author

All is looking great. Can't wait to implement dynamic tree! Great work!

Thank you! I can't wait to implement that either!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants