Repository navigation
iPad touch fixes and automated iPad/WebKit acceptance pass - #279
Conversation
- Touch screens (pointer: coarse) get 16px text fields at every width, so iPadOS Safari no longer zooms the page when the rename field or a dialog field takes focus at 783px and wider. - Toolbar buttons are 44px tall on touch screens at desktop widths (width stays 40px so a 1024px iPad keeps one row). - The width edge handle's hit area is 24px on touch screens, reaching over the page, and a drag starts from where the pointer lands. - New tests/e2e/ipad-acceptance.spec.ts runs the v1.11 iPad checklist at iPad mini/Air portrait and Air landscape with touch input and axe. - v1.11-ACCEPTANCE.md records the automated results and a short hardware script for the remaining real-device and VoiceOver checks. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WPtg9zUtukG2RUBsLEZJ8E
…sories GHSA-3g3m-2fjr-6pw4 (glob 9-14.0.1) and GHSA-g3hv-75wg-m249 (minimatch < 11.0.1) reach the tree only through @wordpress/env > rimraf 5 > glob 10, and fail the npm audit gate on main as well as here. rimraf 5 imports only glob() and globSync(), which glob 14 keeps. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WPtg9zUtukG2RUBsLEZJ8E
|
Dependency metadata + audits failed on two npm advisories published today, not on this PR's changes: GHSA-3g3m-2fjr-6pw4 (glob 9.0.0–14.0.1) and GHSA-g3hv-75wg-m249 (minimatch < 11.0.1). Both reach the tree only through 1938097 ports the fix into this PR: it overrides Generated by Claude Code |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Requested by Dan · project thread
Summary
Automated half of the v1.11 iPad, touch and VoiceOver acceptance pass, plus three iPad fixes it turned up.
pointer: coarse) now get 16px fields at every width.tests/e2e/ipad-acceptance.spec.ts: the checklist's iPad items at iPad mini portrait, iPad Air portrait and landscape with touch input, a mobile viewport and axe inside each dialog..planning/milestones/v1.11-ACCEPTANCE.md: automated results per item and a 7-step hardware script for what still needs a real iPad and VoiceOver.Type of change
Verification
composer test:unit(no PHP changes)composer lintcomposer analyse:phpstannpm run test:jsnpm run check:doc-linksnpm run test:php(CI)npm run test:e2e: locally on WP 7.1.3 + SQLite, 273 passed. One fail is sandbox-only (shared-slug console check saw blocked gravatar requests); the cross-site import test was skipped (needs the second wp-env site).bash bin/build.shAlso ran the checklist flows in real WebKit (WebKitGTK 2.52 via WebDriver): 25 of 25 pass, including axe, WebKit's computed accessible names and roles, and the live-region text (one "Saved" per save; refused separator move speaks its reason).
Notes
.planning/milestones/v1.11-ACCEPTANCE.md).Generated by Claude Code