Skip to content

refactor: Use constant paths in repeating places #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dkorecko merged 3 commits into from
Aug 21, 2025
Merged

refactor: Use constant paths in repeating places #103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a2515c8
done
dkorecko Aug 20, 2025
c6f6914
Merge branch 'main' into refactor/use-constant-paths
dkorecko Aug 21, 2025
fb4fcbf
Merge branch 'main' into refactor/use-constant-paths
dkorecko Aug 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Ticky.Base/Constants.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ public static class Mappings
{
public const string LOGIN_PATH = "/auth/login";
public const string LOGOUT_PATH = "/auth/logout";
public const string BOARD_PATH = "/boards";
}

public static class Policies
Expand Down
10 changes: 5 additions & 5 deletions Ticky.Web/Components/Layout/NavMenu.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
</NavLink>
@if (_user?.LastVisitedBoardId is not null)
{
<NavLink class="nav-link" href=@($"/boards/{_user?.LastVisitedBoardId}")>
<NavLink class="nav-link" href=@($"{Constants.Mappings.BOARD_PATH}/{_user?.LastVisitedBoardId}")>
Recent board
</NavLink>
}
Expand All @@ -52,7 +52,7 @@
Admin Panel
</NavLink>
</AuthorizeView>
<NavLink class="nav-link" href="/auth/logout">
<NavLink class="nav-link" href="@Constants.Mappings.LOGOUT_PATH">
Log out
</NavLink>
</div>
Expand All @@ -77,7 +77,7 @@
</NavLink>
@if (_user?.LastVisitedBoardId is not null)
{
<NavLink class="nav-link" Match="NavLinkMatch.All" href=@($"/boards/{_user?.LastVisitedBoardId}")>
<NavLink class="nav-link" Match="NavLinkMatch.All" href=@($"{Constants.Mappings.BOARD_PATH}/{_user?.LastVisitedBoardId}")>
<span class="fa fa-briefcase" title="Recent board"></span>
</NavLink>
}
Expand All @@ -93,7 +93,7 @@
<Dropdown Actions='new() {
{ "User settings", () => _navigationManager.NavigateTo("/settings") },
{ "Switch theme", () => _js.InvokeVoidAsync("switchTheme") },
{ "Log out", () => _navigationManager.NavigateTo("/auth/logout", true) },
{ "Log out", () => _navigationManager.NavigateTo(Constants.Mappings.LOGOUT_PATH, true) },
}'>
<div class="avatar avatar-border" style="background-image: url('@Constants.ACCESS_UPLOADED_IMAGES_PATH/@_user?.ProfilePictureFileName');"></div>
</Dropdown>
Expand Down Expand Up @@ -140,7 +140,7 @@

private async Task GoToCard(int boardId, int cardId)
{
_navigationManager.NavigateTo($"/boards/{boardId}/{cardId}");
_navigationManager.NavigateTo($"{Constants.Mappings.BOARD_PATH}/{boardId}/{cardId}");
await _js.InvokeVoidAsync("closeDropdowns");
}

Expand Down
30 changes: 29 additions & 1 deletion Ticky.Web/wwwroot/css/app.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/*! tailwindcss v4.1.11 | MIT License | https://tailwindcss.com */
/*! tailwindcss v4.1.12 | MIT License | https://tailwindcss.com */
@layer properties;
@layer theme, base, components, utilities;
@layer theme {
Expand Down Expand Up @@ -244,6 +244,9 @@
::-webkit-datetime-edit, ::-webkit-datetime-edit-year-field, ::-webkit-datetime-edit-month-field, ::-webkit-datetime-edit-day-field, ::-webkit-datetime-edit-hour-field, ::-webkit-datetime-edit-minute-field, ::-webkit-datetime-edit-second-field, ::-webkit-datetime-edit-millisecond-field, ::-webkit-datetime-edit-meridiem-field {
padding-block: 0;
}
::-webkit-calendar-picker-indicator {
line-height: 1;
}
:-moz-ui-invalid {
box-shadow: none;
}
Expand Down Expand Up @@ -380,6 +383,9 @@
.\!h-32 {
height: calc(var(--spacing) * 32) !important;
}
.h-0 {
height: calc(var(--spacing) * 0);
}
.h-0\.5 {
height: calc(var(--spacing) * 0.5);
}
Expand Down Expand Up @@ -446,6 +452,9 @@
.w-2 {
width: calc(var(--spacing) * 2);
}
.w-4 {
width: calc(var(--spacing) * 4);
}
.w-4\/5 {
width: calc(4/5 * 100%);
}
Expand Down Expand Up @@ -512,6 +521,9 @@
.grow {
flex-grow: 1;
}
.border-collapse {
border-collapse: collapse;
}
.border-separate {
border-collapse: separate;
}
Expand Down Expand Up @@ -739,6 +751,9 @@
.bg-app-bg {
background-color: var(--color-app-bg);
}
.bg-backdrop {
background-color: var(--color-backdrop);
}
.bg-backdrop\/0 {
background-color: color-mix(in srgb, oklch(0.446 0.03 256.802) 0%, transparent);
@supports (color: color-mix(in lab, red, red)) {
Expand Down Expand Up @@ -826,6 +841,9 @@
.\!p-0 {
padding: calc(var(--spacing) * 0) !important;
}
.p-0 {
padding: calc(var(--spacing) * 0);
}
.p-0\.5 {
padding: calc(var(--spacing) * 0.5);
}
Expand Down Expand Up @@ -865,6 +883,9 @@
.px-12 {
padding-inline: calc(var(--spacing) * 12);
}
.py-0 {
padding-block: calc(var(--spacing) * 0);
}
.py-0\.5 {
padding-block: calc(var(--spacing) * 0.5);
}
Expand Down Expand Up @@ -1045,6 +1066,9 @@
.capitalize {
text-transform: capitalize;
}
.underline {
text-decoration-line: underline;
}
.opacity-0 {
opacity: 0%;
}
Expand Down Expand Up @@ -1076,6 +1100,10 @@
--tw-shadow: 0 1px 3px 0 var(--tw-shadow-color, rgb(0 0 0 / 0.1)), 0 1px 2px -1px var(--tw-shadow-color, rgb(0 0 0 / 0.1));
box-shadow: var(--tw-inset-shadow), var(--tw-inset-ring-shadow), var(--tw-ring-offset-shadow), var(--tw-ring-shadow), var(--tw-shadow);
}
.outline {
outline-style: var(--tw-outline-style);
outline-width: 1px;
}
.outline-0 {
outline-style: var(--tw-outline-style);
outline-width: 0px;
Expand Down
Loading