Repository navigation
fix: Live updates when running in Docker - #162
Conversation
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. WalkthroughReplaces dynamic Hub URL resolution in Ticky.Web/Components/Pages/BoardView.razor with a prebuilt Uri variable (default Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: ASSERTIVE Plan: Pro Cache: Disabled due to data retention organization setting Knowledge base: Disabled due to data retention organization setting 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes live updates functionality when the application runs in Docker by configuring proper URLs for both the web host and SignalR hub connections based on the build configuration.
Key Changes:
- Configures the web host to listen on
http://0.0.0.0:8080in non-DEBUG (production/Docker) builds - Updates SignalR hub connection to use hardcoded URLs instead of navigation manager's base URI, with conditional logic for DEBUG vs production environments
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| Ticky.Web/Program.cs | Adds conditional URL configuration for Docker deployment (port 8080 for non-DEBUG builds) |
| Ticky.Web/Components/Pages/BoardView.razor | Replaces dynamic hub URL resolution with hardcoded URLs based on build configuration and updates cookie domain accordingly |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Actionable comments posted: 5
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to data retention organization setting
📒 Files selected for processing (2)
Ticky.Web/Components/Pages/BoardView.razor(2 hunks)Ticky.Web/Program.cs(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Analyze (csharp)
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…cko/Ticky into fix/live-updates-in-docker
Summary by CodeRabbit