Skip to content

fix: Properly dispose timer to avoid visual double ticks in time tracking #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dkorecko merged 4 commits into from
Jan 2, 2026
Merged

fix: Properly dispose timer to avoid visual double ticks in time tracking #173

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0e5386e
done
dkorecko Jan 2, 2026
27de5a8
Update Ticky.Web/Components/Dialogs/EditCardModal.razor
dkorecko Jan 2, 2026
9f292c8
full disposal
dkorecko Jan 2, 2026
3751e21
Merge remote-tracking branch 'origin/fix/properly-dispose-timer' into…
dkorecko Jan 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 23 additions & 4 deletions Ticky.Web/Components/Dialogs/EditCardModal.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,11 +513,20 @@

public override void Dispose()
{
if (_pasteObjRef is null)
return;
if (_pasteObjRef is not null)
{
_pasteObjRef.Dispose();
_pasteObjRef = null;
}

if (_timer is not null)
{
_timer.Stop();
_timer.Dispose();
_timer = null;
}
Comment thread
dkorecko marked this conversation as resolved.

_pasteObjRef.Dispose();
_pasteObjRef = null;
base.Dispose();
}

private async Task CopyDeepLink()
Expand Down Expand Up @@ -592,12 +601,22 @@
if(_card is null || targetRecord is null)
{
if (_timer is not null)
{
_timer.Stop();
_timer.Dispose();
}

return;
}

_ongoingTimer = DateTime.Now - targetRecord.StartedAt;
StateHasChanged();

if (_timer is not null)
{
_timer.Stop();
_timer.Dispose();
}

_timer = new System.Timers.Timer(1000);
_timer.Elapsed += OnTimerTick;
Expand Down
Loading