-
Notifications
You must be signed in to change notification settings - Fork 0
[R1-02] Verify and finish PDF highlights and Annotations workflow #30
Copy link
Copy link
Closed
Labels
area:readerPDF reader, text layer, navigation, or citationsPDF reader, text layer, navigation, or citationsarea:storageSQLite schema, migrations, or persistenceSQLite schema, migrations, or persistencearea:uxUser-facing workflow or interfaceUser-facing workflow or interfacephase:1-readingPhase 1: paper reading, selection, and evidence workflowPhase 1: paper reading, selection, and evidence workflowstatus:in-progressImplementation PR exists or work is actively claimedImplementation PR exists or work is actively claimed
Milestone
Description
Activity
Metadata
Metadata
Assignees
Labels
area:readerPDF reader, text layer, navigation, or citationsPDF reader, text layer, navigation, or citationsarea:storageSQLite schema, migrations, or persistenceSQLite schema, migrations, or persistencearea:uxUser-facing workflow or interfaceUser-facing workflow or interfacephase:1-readingPhase 1: paper reading, selection, and evidence workflowPhase 1: paper reading, selection, and evidence workflowstatus:in-progressImplementation PR exists or work is actively claimedImplementation PR exists or work is actively claimed
Outcome
Users can create durable highlights from actual PDF text, find them in Annotations, jump back, and delete them reliably.
Dependencies
Blocked by #29. Existing PR #22 is stacked on PR #21 and must remain ordered. PR #22 implements highlight behavior only; Add to chat and Explain belong to later issue.
Scope
Review PR #22 after #21 lands. Validate text-layer anchors across zoom, navigation, restart, and representative PDFs. Verify migration/IPC/preload/UI and stale-anchor behavior.
Acceptance criteria
Live verification
Use multi-page real PDF. Highlight beginning/end of lines, multi-line selection, repeated text, then zoom, navigate, restart, jump, and delete. Record any PDF.js selection limitations.
Required PR evidence
PR must use
Closes #30, stay focused, and include:npm test,npm run typecheck,npm run build,git diff --check;Existing PR code and mocked tests are not sufficient. Reviewer must independently exercise live flow before merge.