-
Notifications
You must be signed in to change notification settings - Fork 0
[R1-05] Add PDF selection actions: Add to chat and Explain #33
Copy link
Copy link
Closed
Labels
area:acpACP adapter, agent session, or grounding workACP adapter, agent session, or grounding workarea:readerPDF reader, text layer, navigation, or citationsPDF reader, text layer, navigation, or citationsarea:uxUser-facing workflow or interfaceUser-facing workflow or interfacephase:1-readingPhase 1: paper reading, selection, and evidence workflowPhase 1: paper reading, selection, and evidence workflowstatus:in-progressImplementation PR exists or work is actively claimedImplementation PR exists or work is actively claimed
Milestone
Description
Activity
Metadata
Metadata
Assignees
Labels
area:acpACP adapter, agent session, or grounding workACP adapter, agent session, or grounding workarea:readerPDF reader, text layer, navigation, or citationsPDF reader, text layer, navigation, or citationsarea:uxUser-facing workflow or interfaceUser-facing workflow or interfacephase:1-readingPhase 1: paper reading, selection, and evidence workflowPhase 1: paper reading, selection, and evidence workflowstatus:in-progressImplementation PR exists or work is actively claimedImplementation PR exists or work is actively claimed
Outcome
Turn selected paper text into immediate research context. User can add selection to Ask composer or start an explanation grounded in paper.
Dependencies
Blocked by #32. Build on verified reader selection/highlight seam; do not mix into PR #22 retroactively.
Scope
Acceptance criteria
Live verification
On real PDF, test short sentence, equation-adjacent text, multi-line passage, repeated text, page switch, Add to chat edit/send, Explain, backend error, and response grounding against source.
Required PR evidence
PR must use
Closes #33, stay focused, and include:npm test,npm run typecheck,npm run build,git diff --check;Existing PR code and mocked tests are not sufficient. Reviewer must independently exercise live flow before merge.