feat(reader): [R1-05] PDF selection actions: Add to chat and Explain - #56
Merged
Conversation
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #33
User outcome
Users reading a PDF paper in Vellum can select any passage of text and immediately interact with contextual actions:
> "<quote>" (p. <page>)) into the Ask tab's prompt composer without immediately sending, letting users add questions or instructions around it.Acceptance criteria
Automated verification
src/app/SelectionMenu.test.tsxvalidates button actions, color swatch clicks, and keyboard Escape dismissal.src/app/AskPanel.test.tsxvalidates handling ofinjectedPromptwith bothautoSend: falseandautoSend: true.src/app/Reader.test.tsxvalidates text layer selection, floating menu popup, andonAddToChat/onExplaincallback invocation.npm run typecheckpasses with zero errors.npm run buildsucceeds across main (index.cjs), preload (preload.mjs), and renderer.Live Electron verification
xvfbwith Playwright:Vellum.pong.Ask,Notes,Details,Annotations).Visual and console evidence
Window title: VellumFooter status: Vellumbridge: pongTablists: ['No papers open — open one from Library+', 'FilesChats', 'AskNotesDetailsAnnotations']VERIFICATION SUCCESSFULLimitations and follow-ups
Independent review
Reader,RightPanel, andAppshell via explicit callback interfaces.