feat: [L2-01] build hierarchical collections and Library filtering - #58
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #35
User outcome
Users can organize papers into nested local collections in the sidebar folder tree, filter their library by selecting a collection, see live paper count badges, and clear filters without duplicating paper files on disk.
Acceptance criteria
ON CONFLICT DO NOTHING).Automated verification
core/collections/repo.test.ts(6 tests) covering CRUD, cycle detection, re-parenting, idempotent paper assignment, recursive deletion, and tree building with paper counts.core/library/repo.test.ts.CollectionsTreeinsrc/app/CollectionsTree.test.tsx(5 tests).src/app/Library.test.tsx.src/app/Sidebar.test.tsxto verify active CollectionsTree rendering in Files view.npm test.npm run typecheck.npm run build.Live Electron verification
test/collections-live.mjs:window.vellum.ping() -> pong.sample.pdf,sample2.pdf).=== [L2-01] LIVE COLLECTIONS VERIFICATION SUCCESSFUL ===.Visual and console evidence
Filtered by collection: <name>with a workingClear filteraction.Limitations and follow-ups
Independent review
window.vellumpreload bridge andipcRenderer.invoke.