feat: [L2-03] generate and cache paper-specific suggested questions - #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #37
User outcome
Users viewing any paper in the Ask tab receive 3 to 5 insightful, grounded suggested questions reflecting the paper's specific methodology, results, limitations, and practical implications. Clicking any question immediately triggers a grounded Ask turn, and questions can be refreshed or persisted across sessions.
Acceptance criteria
Automated verification
core/store/schema.tsandcore/store/migrate.tscreatingsuggested_questionstable withON DELETE CASCADE.core/questions/repo.tsandcore/questions/repo.test.ts(6 tests) verifying caching, replacement, backend isolation, question derivation from paper structure, and cascade deletion.electron/main.tsand bridge methods inelectron/preload.ts.src/app/SuggestedQuestions.tsxandsrc/app/SuggestedQuestions.test.tsx(4 tests) verifying category badges, click-to-ask, regeneration, and error retry.src/app/AskPanel.tsxandsrc/app/AskPanel.test.tsx(11 tests) verifying suggested question turn execution.npm test).npm run typecheck.npm run build.Live Electron verification
test/questions-live.mjs:questionsGet()for both papers, validating 4 specific questions with categories (methodology,results,limitations,implications).SuggestedQuestionsrenders the question chips with category badges.questionsRegenerate().=== [L2-03] LIVE SUGGESTED QUESTIONS VERIFICATION SUCCESSFUL ===.Visual and console evidence
Methodpurple,Resultsgreen,Limitsorange,Impactblue).Limitations and follow-ups
Independent review
window.vellumpreload API.