Fix #550 - Use dlang.org theme on the editor page#553
Fix #550 - Use dlang.org theme on the editor page#553wilzbach merged 1 commit intodlang-tour:masterfrom
Conversation
| content: " \f0d7"; | ||
| font-family: FontAwesome; | ||
| } | ||
|
|
There was a problem hiding this comment.
Backported from dlang.org
|
|
||
| if (container.className.indexOf("expand-container")) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
this is required, s.t. the link clicks on "Downloads" and "Packages" (i.e. no sections) don't get silently swallowed.
|
A few screenshots:
Mobile
|
That's a good idea only if you want to maintain a third copy of the menu... I'd be inclined to say that this is a better idea: |
I think there are more copies out there: blog.dlang.org, code.dlang.org, VisualD, ...
Maybe in theory, but we already have adopted and trimmed down the menu CSS to a single CSS file and we need to maintain the ability to generate the menu dynamically anyways for the language content. |
More things to fix, then. The next time a major website redesign comes about, we are going to be neck deep into doing pointless work updating all these websites that could have been avoided with a bit of fore-planning and refactoring. Except forum.dlang.org, of course.
Instead of working around things in an unmaintainable manner on your side, please refactor things on the dlang.org side to maximize reuse. |
| toc, title, githubRepo, translations)(); | ||
| } | ||
|
|
||
| private static auto buildDlangToc() |
There was a problem hiding this comment.
Looks so much better than all those DDoc shenanigans at dlang.org!
Btw it's much more likely that we redesign the tour in the meanwhile, e.g. #473 ;-) |
The sooner we move dlang.org to vibe.d diet templates, the sooner this problem would be resolved :P |
FWIW https://github.com/dlang/dlang.org/blob/master/dpl-docs/views/layout.dt |
|
@CyberShadow I think it would be an unreasonable amount of work to import the the dlang.org tour Ddoc templete. Also we can't use submodules here, because sadly DUB still doesn't support them and the tour can be run offline (well currently this only works if you have the language translation, but it's an existing feature). Lastly as mentioned before we/I plan to redesign the DTour a bit in the next few weeks, so we most likely are just going to keep the color schemes and style of dlang.org, which is only CSS anyhow. |
3 participants
Instead of just dumping the menu, I went the "long" road and build the menu statically in D.
This should allow us more flexibility in the future.