Skip to content

Fix Issue 20418: Unittest failure in bitarray.d on Win32#10620

Merged
dlang-bot merged 1 commit intodlang:masterfrom
MoonlightSentinel:fix-bitarray
Nov 26, 2019
Merged

Fix Issue 20418: Unittest failure in bitarray.d on Win32#10620
dlang-bot merged 1 commit intodlang:masterfrom
MoonlightSentinel:fix-bitarray

Conversation

@MoonlightSentinel
Copy link
Copy Markdown
Contributor

A corresponding unittest is (obviously) present but is not executed on the CI systems. See #10612

@dlang-bot
Copy link
Copy Markdown
Contributor

Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
20418 regression Unittest failure in bitarray.d on Win32

⚠️⚠️⚠️ Warnings ⚠️⚠️⚠️

To target stable perform these two steps:

  1. Rebase your branch to upstream/stable:
git rebase --onto upstream/stable upstream/master
  1. Change the base branch of your PR to stable

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#10620"

@dlang-bot dlang-bot merged commit 4061bee into dlang:master Nov 26, 2019
@MoonlightSentinel MoonlightSentinel deleted the fix-bitarray branch December 1, 2019 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants