Enable -preview=fieldwise by default#17495
Conversation
|
Thanks for your pull request and interest in making D better, @pbackus! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#17495" |
d38cdf4 to
040e999
Compare
Introduced in PR dlang#9331, this was changed from a normal bug fix to a -preview switch because enabling it triggered a suprious "statement is not reachable" warning in Phobos. That warning has since been removed (in PR dlang#15568).
040e999 to
0176874
Compare
|
@pbackus - this doesn't do what you think it does. The changelog entry should be removed to avoid confusion, or really make |
This change was accidentally left out of PR dlang#17495.
|
@ibuclaw In the future, when you notice a mistake in a PR, the most helpful thing to do would be to point out the mistake directly. |
This reverts commit 6a7bd45. PR dlang#17495 was originally merged in an incomplete state. Since there are non-trivial obstacles to completing it, revert the incomplete changes instead. See PR dlang#20670 for more information.
|
@pbackus noted - I did post a little in haste. |
Introduced in PR #9331, this was changed from a normal bug fix to a -preview switch because enabling it triggered a suprious "statement is not reachable" warning in Phobos. That warning has since been removed (in PR #15568).