Skip to content

Enable -preview=fieldwise by default#17495

Merged
dlang-bot merged 1 commit intodlang:masterfrom
pbackus:enable-preview-fieldwise
Dec 8, 2024
Merged

Enable -preview=fieldwise by default#17495
dlang-bot merged 1 commit intodlang:masterfrom
pbackus:enable-preview-fieldwise

Conversation

@pbackus
Copy link
Copy Markdown
Contributor

@pbackus pbackus commented Dec 8, 2024

Introduced in PR #9331, this was changed from a normal bug fix to a -preview switch because enabling it triggered a suprious "statement is not reachable" warning in Phobos. That warning has since been removed (in PR #15568).

@dlang-bot
Copy link
Copy Markdown
Contributor

Thanks for your pull request and interest in making D better, @pbackus! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#17495"

@pbackus pbackus force-pushed the enable-preview-fieldwise branch from d38cdf4 to 040e999 Compare December 8, 2024 18:20
Introduced in PR dlang#9331, this was changed from a normal bug fix to a
-preview switch because enabling it triggered a suprious "statement is
not reachable" warning in Phobos. That warning has since been removed
(in PR dlang#15568).
@pbackus pbackus force-pushed the enable-preview-fieldwise branch from 040e999 to 0176874 Compare December 8, 2024 18:26
@dlang-bot dlang-bot merged commit 6a7bd45 into dlang:master Dec 8, 2024
@ibuclaw
Copy link
Copy Markdown
Member

ibuclaw commented Jan 9, 2025

@pbackus - this doesn't do what you think it does. The changelog entry should be removed to avoid confusion, or really make -preview=fieldwise the default.

pbackus added a commit to pbackus/dmd that referenced this pull request Jan 9, 2025
This change was accidentally left out of PR dlang#17495.
@pbackus
Copy link
Copy Markdown
Contributor Author

pbackus commented Jan 9, 2025

@ibuclaw In the future, when you notice a mistake in a PR, the most helpful thing to do would be to point out the mistake directly.

pbackus added a commit to pbackus/dmd that referenced this pull request Jan 9, 2025
This reverts commit 6a7bd45.

PR dlang#17495 was originally merged in an incomplete state. Since there are
non-trivial obstacles to completing it, revert the incomplete changes
instead.

See PR dlang#20670 for more information.
@ibuclaw
Copy link
Copy Markdown
Member

ibuclaw commented Jan 9, 2025

@pbackus noted - I did post a little in haste.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants