Skip to content

build_all.d: Don't run makensis when NoVagrant#736

Merged
ibuclaw merged 1 commit intodlang:masterfrom
ibuclaw:fix_missing_nsis
Mar 2, 2026
Merged

build_all.d: Don't run makensis when NoVagrant#736
ibuclaw merged 1 commit intodlang:masterfrom
ibuclaw:fix_missing_nsis

Conversation

@ibuclaw
Copy link
Copy Markdown
Member

@ibuclaw ibuclaw commented Mar 2, 2026

Error:

[51](https://github.com/dlang/dmd/actions/runs/22587806683/job/65437999779#step:6:6352)
Processing script file: "d2-installer.nsi" (ACP)
ReserveFile: "C:\Program Files (x86)\NSIS\Plugins\x86-unicode\INetC.dll" -> no files found.
Usage: ReserveFile [/nonfatal] [/r] [/x filespec [...]] file [file...] | [/nonfatal] /plugin file.dll
Error in script "d2-installer.nsi" on line 236 -- aborting creation process

Occurs because plug-in is not installed at the time that build_all.d is ran.

This step is rather handled in the GHA template after build_all.d has finished.

./build_all --targets=${{ matrix.target }} "v$LDC" ${{ inputs.release_branch }}
- name: 'Windows: Build NSIS installer'
if: matrix.target == 'windows'
shell: cmd
run: |
:: install NSIS plugin from https://nsis.sourceforge.io/Inetc_plug-in
curl -fsSL https://nsis.sourceforge.io/mediawiki/images/c/c9/Inetc.zip -o inetc.zip || exit /b
7z x inetc.zip -y -bb1 "-oc:\Program Files (x86)\NSIS" || exit /b
:: unpack release .7z generated in previous step
7z x create_dmd_release\build\dmd.${{ inputs.release_branch }}.windows.7z -odmd.windows || exit /b
@echo on
"c:\Program Files (x86)\NSIS\makensis" /version
for /f %%v in (dmd.windows\dmd2\src\VERSION) do set ver=%%v
cd windows || exit /b
"c:\Program Files (x86)\NSIS\makensis" /DVersion2=%ver% /DEmbedD2Dir=..\dmd.windows\dmd2 d2-installer.nsi || exit /b
ren dmd-%ver%.exe dmd-${{ inputs.release_branch }}.exe || exit /b
copy dmd-*.exe ..\create_dmd_release\build || exit /b

@ibuclaw ibuclaw requested a review from dkorpel March 2, 2026 19:14
@ibuclaw ibuclaw added the Windows label Mar 2, 2026
@dlang-bot
Copy link
Copy Markdown
Contributor

Thanks for your pull request, @ibuclaw!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@ibuclaw ibuclaw added the auto-merge-squash Like auto-merge, but squash all the commits into one label Mar 2, 2026
@ibuclaw ibuclaw merged commit 1e669e7 into dlang:master Mar 2, 2026
12 of 14 checks passed
@ibuclaw ibuclaw deleted the fix_missing_nsis branch March 2, 2026 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge-squash Like auto-merge, but squash all the commits into one Windows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants