Skip to content

Switch to using np.arctan2 for Probabilistic Advection #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KristianHMoller wants to merge 2 commits into
base: manage-deps
Choose a base branch
from
Open

Switch to using np.arctan2 for Probabilistic Advection #2

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e561c78
Switch to using np.arctan2 for Probabilistic Advection
KristianHMoller Jun 29, 2026
719da66
Add comment on the use of arctan2
KristianHMoller Jun 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions Models/ProbabilisticAdvection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,10 @@ def ens_forecast(self,
else:
raise Exception('angle_pert_dist must be either normal or vonmises')

pert_motion_field[0, :, :] = pert_abs * np.cos(np.arctan(y / x) + beta_noise)
pert_motion_field[1, :, :] = pert_abs * np.sin(np.arctan(y / x) + beta_noise)
# Use arctan2 for angle calculation to handle all quadrants correctly
base_angle = np.arctan2(y, x)
pert_motion_field[0, :, :] = pert_abs * np.cos(base_angle + beta_noise)
pert_motion_field[1, :, :] = pert_abs * np.sin(base_angle + beta_noise)

yhat_maps = self.extrapolate(self.last_map,
pert_motion_field,
Expand Down