Add ensemble functionality#17
Open
KristianHMoller wants to merge 6 commits into
Open
Conversation
Contributor
Author
|
Scientific question 1: Which values to use for alpha and beta? |
Contributor
Author
|
Implementation question 1: Do we want warning or failure if running deterministically (only one ensemble member) with noise? |
Contributor
Author
|
Implementation question 2: Do we want the number of ensemble members and noise parameters to be CLI arguments rather than environemnt variables? I.e. parameters called when running sunflow: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The underlying probabilistic advection method has the option of running an ensemble with noise. However, until now, this option has not been implemented into
sunflow.This PR allows for running as an ensemble by specifying the environment variable
ENS_MEMBERSto be different from one. Per default, the output will be the ensemble median, but specifying--full_ensemblewhen calling sunflow will instead provide the full ensemble as output. Theoutput_modeglobal attribute in the NetCDF file will specify the type of output: full ensemble, median or deterministic.The default values of the noise parameters alpha and beta are 0 for deterministic mode and using other values will result in a warning.
For ensemble mode, currently, the default values are taken from Carpentieri et al.: https://www.sciencedirect.com/science/article/pii/S030626192301139X
Dependency: Requires this PR to be merged prior to yielding correct results: dmidk/SolarSTEPS#2