Conversation
The Android action sheet from @expo/react-native-action-sheet needed a requestAnimationFrame workaround in useContextMenu to stop a second sheet from silently failing to appear when two were opened back to back. This replaces it on Android with a bottom sheet rendered by the app, which removes the need for that workaround and lets the menu show its title, message, disabled entries, destructive colouring, and an icon per row. ContextMenuSheet owns the pending request itself and is shown through an imperative showContextMenu() call, so nothing has to be threaded through the action sheet context that iOS also consumes. It is mounted only on Android, and the iOS path in useContextMenu is unchanged. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
useContextMenucarried arequestAnimationFrameworkaround on Android to stop a second action sheet from silently failing to appear when two were opened back to back.This replaces the action sheet on Android with a bottom sheet rendered by the app, which removes the need for that workaround and lets the menu show its title, message, disabled entries, destructive colouring, and an icon per row.
Notes
ContextMenuSheetowns the pending request itself and is shown through an imperativeshowContextMenu()call, so nothing is threaded throughActionSheetBgContext— which iOS also consumes. Those files are untouched.iOS
Unaffected. The sheet is mounted only on Android and the iOS branch of
useContextMenuis unchanged.Verification
tsc --noEmitandeslintare clean, and a release build was installed and exercised on a physical device (Android 17, arm64).🤖 Generated with Claude Code