Skip to content

Add missing value support in scikit-learn random forest models - #695

Merged
chyunsu3 merged 5 commits into
dmlc:mainlinefrom
chyunsu3:sklearn_missing_values
Sep 2, 2026
Merged

Add missing value support in scikit-learn random forest models#695
chyunsu3 merged 5 commits into
dmlc:mainlinefrom
chyunsu3:sklearn_missing_values

Conversation

@chyunsu3

@chyunsu3 chyunsu3 commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator

Closes #690

  • Pass in missing_go_to_left array to the model loader.
  • Add unit tests to ensure that missing values are handled correctly.
  • Implement bulk import for IsolationForest

@codecov

codecov Bot commented Aug 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 73.97260% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.97%. Comparing base (b0cc925) to head (fc74eb4).

Files with missing lines Patch % Lines
src/c_api/sklearn.cc 28.00% 18 Missing ⚠️
src/model_loader/sklearn_bulk.cc 97.67% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           mainline     #695      +/-   ##
============================================
- Coverage     84.35%   83.97%   -0.39%     
============================================
  Files            75       75              
  Lines          6867     6908      +41     
  Branches        557      559       +2     
============================================
+ Hits           5793     5801       +8     
- Misses         1074     1107      +33     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chyunsu3

chyunsu3 commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator Author

@trivialfis Can you review?

@chyunsu3 chyunsu3 mentioned this pull request Sep 2, 2026
3 tasks
@chyunsu3
chyunsu3 merged commit b0525f6 into dmlc:mainline Sep 2, 2026
18 of 20 checks passed
@chyunsu3
chyunsu3 deleted the sklearn_missing_values branch September 2, 2026 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support missing values in scikit-learn RandomForest

2 participants