Migrate RMM usage to CCCL MR design#12141
Merged
Merged
Conversation
RMM 26.06 de-templated pool_memory_resource and replaced set_per_device_resource with set_per_device_resource_ref. The pool now holds its upstream via any_resource (owning), so a separate cuda_memory_resource vector is no longer needed in the new code path.
51 tasks
Contributor
hcho3
approved these changes
Apr 23, 2026
Collaborator
hcho3
left a comment
hcho3
left a comment
There was a problem hiding this comment.
LGTM. The #ifdef's looks reasonable: it's restricted to a single source file (helpers.cc)
trivialfis
approved these changes
Apr 24, 2026
Contributor
|
Thanks Bradley and Hyunsu! 🙏 Given this is just in the tests, do we need a patch for building packages or is that unneeded? |
Contributor
|
Also thanks Jiaming! 🙏 Sorry for missing you before 😞 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of rapidsai/rmm#2011.
Depends on rapidsai/rmm#2361.
This updates
tests/cpp/helpers.ccfor API changes in RMM to the new CCCL memory resource design. Thepool_memory_resourceis no longer templated,set_per_device_resourceis replaced byset_per_device_resource_ref, and the pool now holds its upstream via owningany_resourceso a separatecuda_memory_resourcevector is no longer needed. Old RMM code paths are preserved behind version guards for backwards compatibility.