fix(github): remove duplicate PR titles in stack comments#21
Open
laz-canva wants to merge 1 commit intodmmulroy:mainfrom
Open
fix(github): remove duplicate PR titles in stack comments#21laz-canva wants to merge 1 commit intodmmulroy:mainfrom
laz-canva wants to merge 1 commit intodmmulroy:mainfrom
Conversation
GitHub automatically expands #123 references to include the PR title with rich previews (hover cards, status badges, etc.). Previously, ryu was explicitly including both the PR title AND #N, resulting in duplicate titles appearing in comments. Changes: - Updated GitHub formatting to only show "#N" instead of "title #N" - GitHub's auto-expansion will show the title once with rich previews - Updated tests to verify PR titles are not in the markdown source - Renamed test to clarify it checks for no duplicate title This is a breaking change in comment format, but it's a bug fix - the old behavior caused duplication. GitLab formatting is unaffected. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
laz-canva
force-pushed
the
fix-duplicate-pr-titles
branch
from
f7f7fe0 to
9d177d4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes duplicate PR titles appearing in GitHub stack comments by removing the explicit title from the markdown source and relying on GitHub's automatic
#Nexpansion.Problem
When ryu posted stack visualization comments on GitHub PRs, it included both the PR title and the PR number (e.g.,
feat: add auth #123). GitHub automatically expands#123references to include the PR title, resulting in duplicate titles:feat: add auth feat: add auth #123.Solution
Remove the explicit PR title from GitHub comments and use only
#N. GitHub's auto-expansion will show the title once with rich previews (hover cards, status badges, etc.).Before:
After:
GitHub renders this with the full title via auto-expansion, eliminating duplication.
Changes
src/submit/execute.rsto only show#N[title !N](url)format)Testing
Breaking Change
This changes the comment format, but it's a bug fix - the old behavior caused duplication.