Use suggest difficulty#113
Open
Priceless-P wants to merge 1 commit into
Open
Conversation
Fi3
reviewed
Jul 29, 2025
| self.difficulty_mgmt.current_difficulties.clear(); // Clear the initial difficulty | ||
| self.difficulty_mgmt | ||
| .add_difficulty(request.difficulty as f32); | ||
| } |
Contributor
There was a problem hiding this comment.
In think we should also stop doing diff adjustment and close the connection if the suggested diff is completely wrong?
Collaborator
Author
There was a problem hiding this comment.
How do we determine if the suggested diff is completely wrong? @Fi3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr modifies the proxy to use
mining.suggest_difficultyif sent by the mining machine.Depends on dmnd-pool/stratum#13
Fixes: #112