Skip to content

Made subscription id unique#174

Open
psg-19 wants to merge 1 commit into
dmnd-pool:masterfrom
psg-19:feat/unique_id
Open

Made subscription id unique#174
psg-19 wants to merge 1 commit into
dmnd-pool:masterfrom
psg-19:feat/unique_id

Conversation

@psg-19
Copy link
Copy Markdown

@psg-19 psg-19 commented Jan 11, 2026

Fixes #136

Summary :-

  • Added Uuid crate in cargo.toml
  • made new_subscription_id() function to generate id using uuid crate and removed hardcoded value from mod.rs and downstream.rs
  • added test to check id created is unique and in proper format.

@Priceless-P

@jbesraa
Copy link
Copy Markdown
Contributor

jbesraa commented Jan 15, 2026

hey @psg-19
Thanks for looking into this. While your solution is sound and provide a solution for the uniqueness of every id generated, we dont utilize that id between miner(machine) connections. When a machine reconnect we dont retrieve the previous session attached to that miner. Because of that, it feels a bit unnecessary introducing this change now before doing the above.

Ill keep this open for now, and if we plan to maintain mining sessions, we will merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mining.subscribe id is hardcoded

2 participants