refactor: implement robust connection cleanup and fix task leakage#220
Open
rajanarahul93 wants to merge 1 commit into
Open
refactor: implement robust connection cleanup and fix task leakage#220rajanarahul93 wants to merge 1 commit into
rajanarahul93 wants to merge 1 commit into
Conversation
…ownstream task termination
Contributor
|
this need a test that reproduce the issue, it should fail before the patch and pass after. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves a resource leak where downstream background tasks were not correctly terminated upon connection loss. It ensures that if any task associated with a
connection_idexits, a signal is sent to abort all other related tasks.Key Changes
kill_signaltriggers to the exit paths of the Notifier, Updater, Writer, and Share Monitor tasks.returntobreakinreceive_from_downstream.rsto prevent protocol errors from bypassing the cleanup logic.safe_lockcalls andArcmanagement to satisfy Rust'sSendandmoverequirements without introducing redundant logic.Verification
cargo testpassed (8 lib tests, 1 integration test).cargo build.dmnd-client --help.fixes #19