FIX upstream share classification by preserving the aggregate pool target#258
Merged
Conversation
…rget Keep the shared upstream target sourced only from real upstream channel state instead of replacing it when individual downstream channels open. Downstream-specific targets remain per-channel, so share classification continues to compare bitcoin, aggregate upstream, and downstream targets in the intended order. Emit immediate channel retarget updates whenever aggregate nominal hashrate changes during downstream registration, downstream removal, or hashrate reconciliation. This keeps the pool target aligned during connection churn, prevents local-only shares from being escalated upstream, and leaves the submit limiter as a safety net instead of the steady-state control path. Add regression coverage for shared target stability across multiple downstream opens, local classification with distinct downstream targets, and immediate upstream retarget propagation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep the shared upstream target sourced only from real upstream channel state instead of replacing it when individual downstream channels open. Downstream-specific targets remain per-channel, so share classification continues to compare bitcoin, aggregate upstream, and downstream targets in the intended order.
Emit immediate channel retarget updates whenever aggregate nominal hashrate changes during downstream registration, downstream removal, or hashrate reconciliation. This keeps the pool target aligned during connection churn, prevents local-only shares from being escalated upstream, and leaves the submit limiter as a safety net instead of the steady-state control path.
Add regression coverage for shared target stability across multiple downstream opens, local classification with distinct downstream targets, and immediate upstream retarget propagation.