Fix/expected share reduction#90
Draft
Priceless-P wants to merge 2 commits into
Draft
Conversation
e63536b to
97bd979
Compare
jbesraa
reviewed
Jun 25, 2025
Contributor
jbesraa
left a comment
There was a problem hiding this comment.
@Priceless-P I checked to the branch locally and tested and this is what Iam seeing
2025-06-25T10:41:53.447480Z INFO demand_cli::translator::downstream::accept_connection: Translator opening connection for ip 10.100.102.32
2025-06-25T10:41:53.447485Z INFO demand_cli::translator::downstream::accept_connection: Translator initial hash rate for ip 10.100.102.32 is 1000000000000 H/s
2025-06-25T10:41:53.447488Z INFO demand_cli::translator::downstream::accept_connection: Translator share per second for ip 10.100.102.32 is 0.16666667 shares/s
2025-06-25T10:41:53.447501Z INFO demand_cli::translator::downstream::accept_connection: Translator initial difficulty for ip 10.100.102.32 is 1000
2025-06-25T10:41:53.447505Z INFO demand_cli::translator::downstream::accept_connection: Translator expected hash rate for ip 10.100.102.32 is 715827900000 H/s
Contributor
|
this is the initial this seems correct and identical to what is printed above |
Collaborator
Author
|
@jbesraa , please confirm if you are the correct branch. 2025-06-25T10:52:24.504477Z INFO demand_cli::translator::downstream::accept_connection: Translator initial hash rate for ip 127.0.0.1 is 10000000 H/s
2025-06-25T10:52:24.504501Z INFO demand_cli::translator::downstream::accept_connection: Translator share per second for ip 127.0.0.1 is 0.16666667 shares/s
2025-06-25T10:52:24.504523Z INFO demand_cli::translator::downstream::accept_connection: Translator initial difficulty for ip 127.0.0.1 is 0.02
2025-06-25T10:52:24.504544Z INFO demand_cli::translator::downstream::accept_connection: Translator expected hash rate for ip 127.0.0.1 is 14316558 H/s |
Contributor
|
here are last commits on the branch iam on I tried it another couple of times: Try to add more tests to cover different larger numbers |
eeb29c0 to
d6e1975
Compare
d6e1975 to
05c450c
Compare
05c450c to
6f30edb
Compare
Fi3
approved these changes
Jul 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The expected hash rate is ~30% lower than the
-dvalue due to aggressive difficulty rounding. This change:-dvalue.cargo fmt,clippyandtestissues introduced by the previous pr merges