Skip to content

Rework check commands: --strict and --no-fail flags - #37

Merged
theoephraim merged 1 commit into
mainfrom
fix/empty-bump-file-detection
Apr 22, 2026
Merged

theoephraim merged 1 commit into
mainfrom
fix/empty-bump-file-detection

Conversation

@theoephraim

@theoephraim theoephraim commented Apr 22, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Default behavior now only fails when no bump files exist at all (matching changesets behavior) — uncovered packages produce a warning but don't block
  • --strict flag for both bumpy check and bumpy ci check — fails if any changed package is not covered by a bump file
  • --no-fail flag — advisory-only mode, never exits non-zero
  • Fix false positive "empty bump file found" when deleted bump files from other branches appear in git diff
  • Uses log.error (stderr) when failing, log.warn (stdout) when not
  • Removed --fail-on-missing from ci check (superseded by new flags)
  • Shows existing bump file paths in check output for easy navigation
  • Contextual hints: suggests none bump type in strict mode, --empty in default mode
  • Updated docs: CLI reference, bump files guide, differences from changesets, README

Test plan

  • All existing tests pass
  • bumpy check warns about uncovered packages but exits 0 (default)
  • bumpy check --strict would exit 1 for uncovered packages
  • Deleted bump files from other branches no longer trigger false "empty bump file" detection

🤖 Generated with Claude Code

@bumpy-bot

bumpy-bot commented Apr 22, 2026 •

Copy link
Copy Markdown
Collaborator

bumpy-frog

The changes in this PR will be included in the next version bump.

minor Minor releases

  • @varlock/bumpy 1.1.0 → 1.2.0

Bump files in this PR

Click here if you want to add another bump file to this PR


This comment is maintained by bumpy.

@theoephraim
theoephraim force-pushed the fix/empty-bump-file-detection branch from dd2c7fd to fa1ea46 Compare April 22, 2026 04:28
@theoephraim theoephraim changed the title Fix false positive empty bump file detection Rework check commands: --strict and --no-fail flags Apr 22, 2026
- Default: only fail when no bump files exist at all (matches changesets)
- --strict: fail if any changed package is uncovered
- --no-fail: advisory-only, never exit non-zero
- Fix false positive empty bump file detection from deleted files
- Use log.error when failing, log.warn when not
- Update docs for new flags, none bump type, and removed --fail-on-missing

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@theoephraim
theoephraim force-pushed the fix/empty-bump-file-detection branch from fa1ea46 to d5771b2 Compare April 22, 2026 04:35
@theoephraim
theoephraim merged commit 1d74f27 into main Apr 22, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants