Skip to content

Improved connector provision and updated dependencies#39

Merged
lucienclin merged 3 commits into
mainfrom
refactor-connector-provision
Jun 1, 2026
Merged

Improved connector provision and updated dependencies#39
lucienclin merged 3 commits into
mainfrom
refactor-connector-provision

Conversation

@lucienclin

@lucienclin lucienclin commented Jun 1, 2026

Copy link
Copy Markdown
Contributor
  • Bump dependency versions
  • Refactor connector provision

Summary by CodeRabbit

Release Notes

  • Chores

    • Updated service dependencies including service-base, validation services, query services, and connector libraries to latest versions.
  • Improvements

    • Refined peer-to-peer connector handling with enhanced query parameter formatting.
    • Updated validation reporting endpoint behavior.

@coderabbitai

coderabbitai Bot commented Jun 1, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 749043d4-de83-4903-8660-0dd3972fbc88

📥 Commits

Reviewing files that changed from the base of the PR and between aea2907 and f842912.

📒 Files selected for processing (2)
  • app/controllers/de/dnpm/dip/rest/api/UseCaseController.scala
  • build.sbt

📝 Walkthrough

Walkthrough

The PR updates the API gateway's UseCaseController to integrate with new versions of the DNPM services. Library dependencies are bumped, and the controller's validation endpoints and peer-to-peer orchestrator connector logic are refactored to use updated APIs: validation now uses a command pattern, reporting calls a validationReport method, and local controlling info wiring simplifies connector setup with direct HttpConnector parameterization.

Changes

UseCaseController service integration and dependency updates

Layer / File(s) Summary
Library dependency version updates
build.sbt
Multiple de.dnpm.dip service and connector libraries (service-base, mtb-validation-service-api/impl, mtb-query-service-api/impl, rd-validation-service-api/impl, rd-query-service-api/impl, connector-base) are upgraded to newer versions.
Validation service endpoint changes
app/controllers/de/dnpm/dip/rest/api/UseCaseController.scala
The Validate message type is imported. The validate endpoint switches from direct method call validationService.validate(req.body) to command injection validationService ! Validate(req.body, persist = false). The validationReport endpoint calls validationService.validationReport(id) instead of validationService.dataQualityReport(id).
Orchestrator peer-to-peer connector wiring
app/controllers/de/dnpm/dip/rest/api/UseCaseController.scala
HttpConnector.QueryParameters is imported. The orchestrator's LocalControllingInfo request handler removes sys.props-driven broker-type selection and FakeConnector fallback, replacing them with a direct HttpConnector route that builds query parameters with ISO-local-date formatting for episode.start and optional episode.end.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • dnpm-dip/api-gateway#38: Both PRs modify UseCaseController's peer-to-peer local controlling-info/orchestrator route wiring (the retrieved PR refactors the useCase-driven URL/path handling while the main PR changes how that route builds the HttpConnector + query parameters).

Poem

🐰 With dependencies bumped and connectors made bright,
The orchestrator wires its peers just right,
Validation commands now flow through the stream,
Query parameters formatted like a dream,
The gateway's connections now dance in the night! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Improved connector provision and updated dependencies' directly reflects the main changes: refactored connector provision in UseCaseController and bumped dependency versions in build.sbt.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refactor-connector-provision

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@lucienclin

Copy link
Copy Markdown
Contributor Author

@coderabbitai please review now

@coderabbitai

coderabbitai Bot commented Jun 1, 2026

Copy link
Copy Markdown

@lucienclin Sure, I'll start reviewing the changes right away!

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@lucienclin
lucienclin merged commit 0e04b04 into main Jun 1, 2026
2 checks passed
@lucienclin
lucienclin deleted the refactor-connector-provision branch June 1, 2026 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant