Expose erldns:stop_listeners/0 - #363
Merged
Merged
Conversation
The mirror of start_listeners/0: an embedding application that defers the listeners at boot (autostart_listeners=false) until its own resources are up has no way to close them again before those resources are torn down, so a query served during shutdown can reach a pipeline stage whose ETS tables have already died with their owner. stop_listeners/0 terminates the erldns_listeners child, keeping its spec, and start_listeners/0 now falls back to restart_child/2 when the spec is present, so the pair is symmetric.
NelsonVides
added
the
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mirror of start_listeners/0: an embedding application that defers the listeners at boot (autostart_listeners=false) until its own resources are up has no way to close them again before those resources are torn down, so a query served during shutdown can reach a pipeline stage whose ETS tables have already died with their owner.
🔍 QA
N/A
📋 Deployment Pre/Post tasks
N/A
N/A