This repository was archived by the owner on Aug 19, 2026. It is now read-only.
fix(setup): serialize one-time setup completion to prevent owner-account race - #639
Open
dnviti wants to merge 1 commit into
Open
fix(setup): serialize one-time setup completion to prevent owner-account race#639dnviti wants to merge 1 commit into
dnviti wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens the unauthenticated first-run setup completion flow against concurrent/raced requests by serializing setup completion within the database transaction and re-checking setup state under that serialization.
Changes:
- Added a transaction-scoped PostgreSQL advisory lock (
pg_advisory_xact_lock) increateSetupAdminto serialize concurrent setup completion attempts. - Added
isSetupRequiredTxto re-checksetupCompletedand user existence inside the same transaction, returning409 Conflictwhen setup is already completed.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+256
to
+258
| // Serialize one-time setup completion attempts for this database. | ||
| if _, err := tx.Exec(ctx, `SELECT pg_advisory_xact_lock($1)`, int64(84572133)); err != nil { | ||
| return "", fmt.Errorf("acquire setup lock: %w", err) |
Comment on lines
+256
to
+259
| // Serialize one-time setup completion attempts for this database. | ||
| if _, err := tx.Exec(ctx, `SELECT pg_advisory_xact_lock($1)`, int64(84572133)); err != nil { | ||
| return "", fmt.Errorf("acquire setup lock: %w", err) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
POST /api/setup/completeflow could be raced: parallel callers could all observe zero users and each create an OWNER account and tenant.Description
pg_advisory_xact_lockincreateSetupAdminto serialize concurrent setup completion attempts.isSetupRequiredTxthat validatessetupCompletedand user existence inside the same transaction and returns a409(requestError) when setup is already completed.backend/internal/setup/complete.go.Testing
go test ./backend/internal/setup/...which reported no test files for the package (smoke check completed).go test ./backend/cmd/control-plane-api/...which succeeded (ok).Codex Task