This repository was archived by the owner on Aug 19, 2026. It is now read-only.
Harden query-runner compose exposure - #640
Open
dnviti wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Hardens the production Podman Compose deployment by preventing the internal query-runner SQL execution API from being published on host network interfaces, keeping it reachable only from other services on the internal compose networks.
Changes:
- Removed the
portsmapping for the productionquery-runnerservice so it is no longer exposed on host port18093. - Kept
query-runnerconfiguration (env, secrets, healthcheck, networks, dependencies) otherwise unchanged.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
418
to
424
| PORT: "8093" | ||
| ARSENALE_VERSION: "{{ arsenale_image_tag }}" | ||
| DATABASE_URL_FILE: /run/secrets/database_url | ||
| DATABASE_SSL_ROOT_CERT: /certs/postgres/ca.pem | ||
| ports: | ||
| - "{{ arsenale_service_bind_host | default('0.0.0.0') }}:{{ arsenale_query_runner_port | default(18093) }}:8093" | ||
| depends_on: | ||
| postgres: | ||
| condition: {{ _compose_dependency_condition }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
query-runnerservice on host port18093(bound viaarsenale_service_bind_hostdefaulting to0.0.0.0), which exposed an unauthenticated internal SQL execution API to external networks and allowed arbitrary SQL against the application database.Description
portsmapping for thequery-runnerservice indeployment/ansible/roles/deploy/templates/compose.yml.j2so the service is no longer published on host interfaces and remains reachable only via internal compose networks, while keeping its environment, secrets, healthcheck, and internal networking intact.Testing
go test ./tools/arsenale-cli/...which completed successfully.Codex Task