Add support for state_header access in the SDK - #205
Open
ed255 wants to merge 22 commits into
Open
Conversation
ed255
commented
Jul 29, 2026
| /// slot index is `ts - 1` and the step name is `step_{ts-1}`. | ||
| pub(crate) fn chain_step_at(ts: usize, chain_max_ts: usize) -> Option<usize> { | ||
| (chain_packed(chain_max_ts) && ts > 0 && ts < chain_max_ts).then_some(ts - 1) | ||
| (chain_packed(chain_max_ts) && ts > 0 && ts < chain_max_ts).then(|| ts - 1) |
Collaborator
Author
There was a problem hiding this comment.
There was an underflow here (which was detected in debug mode).
On underflow this results in None, but in debug an underflow panics. By using a closure the subtraction only happens when the check passes.
ed255
force-pushed
the
feat/actiom-state-3
branch
from
July 29, 2026 16:50
8150748 to
dffc01c
Compare
ed255
force-pushed
the
feat/actiom-state-3
branch
from
July 29, 2026 17:08
dffc01c to
b46f259
Compare
ed255
force-pushed
the
feat/actiom-state-3
branch
from
July 29, 2026 17:49
1fccba6 to
2c61de0
Compare
Collaborator
|
what does |
Collaborator
|
FYI - confirmed e2e objects are produced and synchronizer runs fine Some docs are outdated and the GUI rendering is broken cuz of the new object structure but I updated those here #206 |
dhvanipa
reviewed
Jul 30, 2026
Collaborator
Author
This is inspired by the read/write/execute flags of files display in Unix. So
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #201
I had to merge the In/Out records into a single IO one because even after the splitter did its thing, there were predicates that had 9 wildcards (our max is 8).
I believe this change doesn't introduce any performance regression and gets rid of one wildcard in some occasions.
Note for the reviewer: I haven't yet tested the correct behavior of the synchronizer after this PR nor an end 2 end flow because I don't have access to my everyday machine and I did this on 8GB of RAM 🫠