ci: skip windows release checksums and sigstore bundles - #3978
Merged
Conversation
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
thaJeztah
reviewed
Jul 28, 2026
| mv "sbom-binaries.spdx.json" "${filename}.sbom.json" | ||
| find . -name 'sbom*.json' -exec rm {} \; | ||
| if [[ "$binname" == *darwin* ]]; then | ||
| if [[ "$binname" == *darwin* ]] || [[ "$binname" == *windows* ]]; then |
Member
There was a problem hiding this comment.
Do we have tracking issues for the remaining work for this? (wondering if a TODO + link is warranted here)
Member
Author
There was a problem hiding this comment.
No public tracking issue that I know of yet. The intent here is to match the existing Darwin flow because Windows binaries will now be signed by the downstream workflow after the Buildx release assets are uploaded, so we should not publish checksums for the unsigned Windows binaries that will be replaced.
I will look to add something in our README.
suzuki-shunsuke
pushed a commit
to aquaproj/aqua-registry
that referenced
this pull request
Aug 29, 2026
* fix(docker/buildx): Windows has no Sigstore bundle from v0.36.0 Upstream stopped publishing Sigstore bundles for the Windows binaries - 15 bundles on v0.35.0, 13 from v0.36.0, with only windows-amd64 and windows-arm64 missing. The binaries themselves are still published, so only the cosign step fails. This is deliberate. The v0.36.0 notes say "Windows release binaries are now code-signed, matching the signing coverage already provided for macOS release artifacts" (docker/buildx#3978), so Windows moved to the model macOS already used - and the config already disables cosign for macOS. Split the `true` branch and add a windows override that disables cosign. Only cosign is disabled there; checksums.txt verification stays on, unlike darwin where the checksum is also disabled for an unrelated upstream bug. The boundary is the release candidate: v0.36.0-rc1 still ships the Windows bundles and v0.36.0-rc2 is the first without them, so the split is at semver("< 0.36.0-rc2"). Verified with aqua v2.62.3 on macOS 26.6.2 with checksum verification enabled: v0.36.1 installs on windows/amd64, windows/arm64, linux/amd64 and darwin/arm64, v0.36.0 installs on windows, and v0.36.0-rc1, v0.35.0 and v0.30.1 are unaffected with the Windows bundle still verified on the old branch. cosign is still enforced on linux in the new branch, which reports Verified OK. `argd t docker/buildx` exits 0 for all six os/arch targets. pkg.yaml is left unchanged so the updater keeps ownership of the version bump. This unblocks the 2 stuck update PRs for this package. registry.yaml is regenerated by `argd gr`. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * test(docker/buildx): pin v0.36.0-rc2 so CI exercises the new branch Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * test(docker/buildx): move the updater slot into the new branch Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the Buildx release workflow so Windows artifacts are handled like Darwin artifacts before the external signing handoff.
Windows binaries are signed by a downstream workflow, which downloads the Buildx release assets, keeps the Darwin and Windows binaries, signs them, verifies the signatures, and uploads the signed binaries back to the release. Skipping Windows checksums here avoids publishing checksums for pre-signed binaries that will be replaced by the signing workflow.