fix(devops): Enable HMR/Watch by correcting CMD and NODE_ENV#63
Open
mateusmtorres23 wants to merge 1 commit intodocker:mainfrom
Open
fix(devops): Enable HMR/Watch by correcting CMD and NODE_ENV#63mateusmtorres23 wants to merge 1 commit intodocker:mainfrom
mateusmtorres23 wants to merge 1 commit intodocker:mainfrom
Conversation
…es the Dockerfile CMD to use 'nodemon server.js' and overrides NODE_ENV to 'development' in compose.yaml to enable the hot-reloading feature.
Author
|
Hello maintainers, I encountered an issue where the docker compose watch feature failed to enable hot-reloading for the Node.js service due to a conflict between the Dockerfile and compose.yaml environments. This PR corrects the CMD to use nodemon and sets the NODE_ENV to development to ensure the tutorial's intended development experience is functional. Thanks for the review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the Dockerfile CMD to use 'nodemon server.js' and overrides NODE_ENV to 'development' in compose.yaml to enable the hot-reloading feature.