Repository navigation
v1.5.4: fix 4G activation flag byte - #42
Merged
Merged
Conversation
The 4G per-frame payload prefix was 00 00 00; the third byte is the activation flag and must be 01 to request 4G ON. Sending 00 made the 128 frames a no-op. Payload is now 00 00 01 + ASCII serial. Combined with the earlier gate fix (which previously blocked 4G from being sent at all), this is the first build where 4G can actually run end to end. 4G remains experimental and needs on-hardware confirmation on a dongle-equipped aircraft; the FCC path is unchanged. Bump versionName 1.5.2 -> 1.5.4, versionCode 20 -> 21.
The signed-release job now also runs on a `v*` tag push (not just manual dispatch) and, when signing secrets are present, attaches the signed app-release.apk to the GitHub Release for that tag (creating the release with generated notes if it doesn't exist yet). This keeps the stable /releases/latest/download/app-release.apk URL working automatically.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
00 00 00; the third byte is the activation flag and must be01. Sending00made the 128 frames a no-op. Payload is now00 00 01+ ASCII serial.Why it matters
Combined with the gate fix that previously blocked 4G from being sent at all (#40), this is the first build where 4G can run end to end. Still experimental — needs on-hardware confirmation on a dongle-equipped aircraft.
Safety
assembleRelease+ unit tests green.Release scope (v1.5.4 also bundles what's on
mainsince v1.5.3)