Repository navigation
v1.5.5: robust aircraft serial detection + manual entry - #45
Merged
Merged
Conversation
Serial detection was passive-only with a 1.5s window and a 1581-only regex, so it came up empty on many setups — the field cause of the 4G "serial too short" failures. It now: - actively queries the aircraft (and controller) for the serial with a version/serial inquiry (cmdSet 0, cmdId 87/1) and parses the reply, - reassembles 55 CC 30 75 length-prefixed telemetry chunks, - listens passively up to 8s as a fallback, - accepts any 8-32 char alphanumeric serial, not just 1581... ones, - adds a manual serial entry field that always takes priority over auto-detection (the reliable fallback when nothing surfaces it). Bump versionName 1.5.4 -> 1.5.5, versionCode 21 -> 22.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the serial detection that was failing in the field (the root of the 4G "serial too short" reports).
55 CC 30 75length-prefixed telemetry chunks.1581…(some aircraft use other formats).FCC path untouched. Built + unit tests green locally.