[pull] master from mapeditor:master - #114
Merged
Merged
Conversation
The resize handles now also work on maps that are not part of any world. Resizing only changes the map itself, so it does not need a world, and undo goes through the map's own undo stack. The view is kept steady by compensating for the content shift, which now uses the same computation whether or not the map is in a world. Arrow keys scroll the view when the map cannot be moved. Added an explicit "New World for Map" action to the World Tool, which asks for a world file name and creates a new world containing the current map. It is shown in place of the "Add another map" action when the current map is not in a world, guiding the user to create one first. The New World dialog is now shared with the "World > New World" menu action through MainWindow::createNewWorld, which suggests a file name based on the map and explicitly handles selecting an already loaded world. Also fixed the session forgetting its loaded worlds in some cases, by remembering them right before switching session or quitting, and fixed newly created worlds having an empty canonical file path. Co-authored-by: Thorbjørn Lindeijer <bjorn@lindeijer.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )