[pull] master from mapeditor:master - #117
Merged
Merged
Conversation
) * improve TileLayer performance by replacing dirty flag tileset scan with incremental ref counting * libtiled: Use a single hash for TileLayer tileset reference counting As suggested by the maintainer, use a single QHash<SharedTileset, int> for tracking tileset usage in TileLayer. This simplifies the implementation and avoids the need to rebuild the reference counts in most cases. Also: - Inline addTilesetRef and removeTilesetRef into setCell with caching of SharedTileset for performance. - Update referencesTileset to use O(1) lookup with qSharedPointerConstCast to handle the const/non-const SharedTileset mismatch. - Update removeReferencesToTileset and replaceReferencesToTileset to update the hash directly. - Ensure TileLayer::usedTilesets returns the set of keys from the hash. * libtiled: Restore hasCell() doc comment and drop unneeded mutable The comment was lost in the refcount rewrite, and mUsedTilesets no longer needs to be mutable now that the lazy rebuild is gone. Co-authored-by: rhythmcache <153998419+rhythmcache@users.noreply.github.com>
The generated moc_*.cpp files are tagged with "hpp" when they are included by a source file rather than compiled separately, since in that case they behave like headers. This caused them to be matched by the install group using 'fileTagsFilter: "hpp"' and to be installed to the include directory. Now the source headers are explicitly tagged with an additional "public_hpp" tag, which the install group matches instead. Generated artifacts are not affected by FileTagger items, so the moc files are no longer installed. Closes #4260
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )