[pull] master from mapeditor:master - #119
Merged
Merged
Conversation
When undoing a resize from the left/top edge, the resize gets undone but the whole map jumps in the view. Same problem when undoing a map move in a world, the other maps move in the view instead of the moved one going back. This happens because the view was only adjusted when the change was made through the tool, so undo/redo never adjusted it. Now the ResizeMap command reports the contents shift through the mapResized signal and MapScene adjusts the view when it happens. For maps that are in a world, refreshScene compensates for the change in world position instead. So the view stays steady no matter where the change came from. The shift, and the world position, are measured from the map's bounding rect, which handles the isometric origin depending on the map height and the half tile hexagonal and staggered contents jump when the stagger parity changes. The resize handle counts the new size from the size the map started at, instead of dividing the map bounds by the tile size.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )