[pull] master from mapeditor:master - #126
Merged
Merged
Conversation
#4614) setProperty and setProperties did not check whether the asset is read-only when there was no document, unlike removeProperty and setClassName. This allowed modifying the map or tileset passed to the write function of a scripted format, which bypasses the undo stack of the document being saved. Now they raise the "Asset is read-only" error as well.
Forwards the selection change signal of the tileset document, so that extensions no longer need to poll Tileset.selectedTiles. The tileset editor now also avoids setting the selection on the document again after updating its view to match the document, which would have caused the signal to be emitted twice for a change made from script.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )