[pull] master from mapeditor:master - #127
Merged
Merged
Conversation
Scripts can load worlds through WorldManager, but this didn't work for evaluation from the command-line because it unnecessarily required a DocumentManager. The same GUI guard prevented worldsChanged from being forwarded, and loadWorld discarded loading errors. Read worlds and connect their change notification independently of the GUI, propagate load failures as script errors, and document the error behavior. Add a scripting test target that runs the public JavaScript API without creating a DocumentManager, covering load/unload visibility, change notifications, and a missing world file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )