[pull] master from mapeditor:master - #76
Merged
Merged
Conversation
Resolved by only popping up the error dialog when explicitly trying to add a member. When it happens just because the focus on the add value widget is lost, we silently abort when there is an existing member with the same name. This avoids the problem because in fact the "addRequested" signal is currently always emitted two times: once by the user pressing Enter or clicking somewhere, and then another time when the add value widget loses focus. A more proper fix might be to make sure we only emit this signal once.
Currently translated at 100.0% (1486 of 1486 strings)
Releases were not working due to the following issue: > Skip output 'release' since it may contain secret. This was resolved by scoping the SIGNING_ENABLED secret more narrowly. Also, the 'release' output was removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )