Add max_units option to stringify, so that the maximum unit is specified#8
Open
igitur wants to merge 5 commits into
Open
Add max_units option to stringify, so that the maximum unit is specified#8igitur wants to merge 5 commits into
igitur wants to merge 5 commits into
Conversation
Owner
|
Thanks for this. I’d love it if there were some test coverage for this feature. Thanks again |
Author
|
Yes, I didn't even notice the tests. Will add them for both my PRs. |
Owner
|
Great, thanks |
Author
|
Test cases added. |
Author
|
ping |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows the parser to assume a certain unit if no units were specified in the input string. For example, in my case, I want to display 48h still in hours and not as 2 days. It's just a project requirement.