Skip to content

Output mode for printing playlists of similar tracks#51

Open
iammordaty wants to merge 1 commit into
dominikschnitzer:masterfrom
iammordaty:feature-output-mode
Open

Output mode for printing playlists of similar tracks#51
iammordaty wants to merge 1 commit into
dominikschnitzer:masterfrom
iammordaty:feature-output-mode

Conversation

@iammordaty
Copy link
Copy Markdown

@iammordaty iammordaty commented Nov 7, 2019

Hello! In musly command line tool, I added the ability to change output mode. The new mode allows printing a playlist of similar tracks in a similar way as when listing files from the collection.

Please see an example outputs below:

$ musly -p test/2.mp3 # or: musly -o short -p test/2.mp3
[...]
Computing the k=5 most similar tracks to: test/2.mp3
audio/3.mp3
test/1.mp3
test/5.mp3
test/4.mp3

$ musly -o long -p test/2.mp3
[...]
Computing the k=5 most similar tracks to: test/2.mp3
track-id: 3, track-distance: 0.720967, track-origin: test/3.mp3
track-id: 2, track-distance: 0.837826, track-origin: test/1.mp3
track-id: 1, track-distance: 0.910639, track-origin: test/5.mp3
track-id: 4, track-distance: 0.93015, track-origin: test/4.mp3

Copy link
Copy Markdown
Collaborator

@f0k f0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @iammordaty, thank you for the PR and sorry for the late reply! This looks useful indeed, and implementing it as a string option would enable other formats in the future (such as a CSV). I left a few comments in the code. Let me know what you think.

Comment thread musly/programoptions.cpp
Comment thread musly/main.cpp
float d = track_idx[i].second;

pl << "track-id: " << j << ", track-distance: " << d
<< ", track-origin: " << tracks_files[j] << std::endl;
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in principle! I think we should omit the track- prefixes, though. And track-origin could just become filename? And I'm a bit unsure if the track id is useful, since users do not have a way to set it anyway. Would you have a use case in mind?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should omit the track- prefixes, though. And track-origin could just become filename?

I thought about consistency with the 'list files' mode, but if there is no such need, I will remove track- prefixes and change track-origin to filename - it clearly indicates what it is and just looks better :-)

And I'm a bit unsure if the track id is useful, since users do not have a way to set it anyway. Would you have a use case in mind?

Thank you for pointing this out, I had doubts about adding it.
As above, I added this field to be consistent with file listing mode. I noticed that this is not a "real" track identifier, but I left it at MR to talk about it to make sure.

Copy link
Copy Markdown
Author

@iammordaty iammordaty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @f0k! Never mind, thanks for the answer and the code review!

@iammordaty iammordaty requested a review from f0k January 23, 2021 00:33
@iammordaty
Copy link
Copy Markdown
Author

Hi, @f0k! Is there any chance of accepting this MR? If I should change anything else, please let me know. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants