Replace shell exec with execFile in CLI tests to eliminate shell injection risk#171
Draft
Copilot wants to merge 2 commits into
Draft
Replace shell exec with execFile in CLI tests to eliminate shell injection risk#171Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
…ty alert Agent-Logs-Url: https://github.com/donatj/CsvToMarkdownTable/sessions/2838ac05-aff9-4f4a-bcd2-9bff5b62d9e7 Co-authored-by: donatj <133747+donatj@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Autofix Code Scanning Alert
Replace shell exec with execFile in CLI tests to eliminate shell injection risk
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests were using
execwith template-literal shell commands (cat ${tempFilePath} | ${cliPath} --delim ...), flagged by CodeQL as "Shell command built from environment values."Potential fix for alerts
Changes
exec→execFile: Replaced shell-spawningexec/execAsyncwithexecFile/execFileAsyncthroughout the test file; no shell is invoked, so variable interpolation into shell strings is eliminatedexecFileWithInputhelper: PromisifiedexecFilehas noinputoption (unlike sync variants), so a small helper wraps the callback form and writes directly tochild.stdin:cat file | cmdinvocations replaced withfs.readFileSync+execFileWithInput, passing CSV content directly as stdin--help,--invalid-arg,--delimedge cases) useexecFileAsyncwith an explicit args array