Small handful of lessons learned from upgrading a different node project.#178
Merged
Conversation
|
coverage: 98.413%. remained the same — small-fixes into master |
Added a check to ensure the generated lib is clean after build.
There was a problem hiding this comment.
Pull request overview
This PR updates the package entrypoints/exports and CI checks based on lessons learned from a Node project upgrade, aiming to improve module resolution compatibility and keep generated build artifacts consistent.
Changes:
- Adjust
package.jsonmainandexportsto better align CJS/ESM/browser entrypoints and include adefaultexport target. - Update CI Node matrix (swap 25.x for 26.x) and add a workflow step to fail if
./libchanges after the build. - Mark
lib/**as generated for GitHub Linguist.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Updates module entrypoints and conditional exports (CJS/ESM/browser/types/default). |
| .github/workflows/ci.yml | Updates Node test matrix and adds a post-build check to ensure lib/ stays unchanged. |
| .gitattributes | Marks lib/ outputs as generated for repository language stats. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.